Skip to content

test(subscription): Add more tests Subscriptions::UpdateService #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

test(subscription): Add more tests Subscriptions::UpdateService #3948

merged 1 commit into from
Jul 9, 2025

Conversation

groyoh
Copy link
Contributor

@groyoh groyoh commented Jul 8, 2025

Context

While working on the Subscriptions::UpdateService, I noticed some test cases missing and some tests incomplete.

Description

This PR adds/updates those tests.

@groyoh groyoh changed the title test(subscription): Add more test Subscriptions::UpdateService test(subscription): Add more tests Subscriptions::UpdateService Jul 8, 2025
@groyoh groyoh force-pushed the test/subscription-update branch from 52d1a32 to 36e3826 Compare July 8, 2025 16:07
@groyoh groyoh marked this pull request as ready for review July 8, 2025 16:18
Base automatically changed from chore/subscription-factory to main July 9, 2025 06:45
@groyoh groyoh force-pushed the test/subscription-update branch from 36e3826 to de5c8e6 Compare July 9, 2025 06:46
@groyoh groyoh merged commit 9f9e885 into main Jul 9, 2025
14 checks passed
@groyoh groyoh deleted the test/subscription-update branch July 9, 2025 06:51
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@groyoh @diegocharles
test(subscription): Add more tests Subscriptions::UpdateService (#3948
ac8f70b 
)

## Context

While working on the `Subscriptions::UpdateService`, I noticed some test cases missing and some tests incomplete. 

## Description

This commit adds/updates those tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groyoh @vincent-pochet