fix: prevent cascading when overridden plan is not linked to active sub #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
reviewed
Jul 7, 2025
That is true. Earlier today I was also double-checking it with Mike and we also concluded that it makes sense to include pending ones. |
julienbourdeau
approved these changes
Jul 7, 2025
b1528ff to
f53d8f7
Compare
There is difference between plan and charge query, but you are right that charge one can use the scope 👍 Will open another PR with scope and proper tests for the scope |
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…ub (#3934) ## Context Currently cascade feature targets all overridden plans even if linked subscription is terminated ## Description Described scenario can lead to performing unnecessary cascading and this PR fixes it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently cascade feature targets all overridden plans even if linked subscription is terminated
Description
Described scenario can lead to performing unnecessary cascading and this PR fixes it