fix(usages): Fix usage date - use customer timezone #3911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures DailyUsages::FillFromInvoiceService computes usage_date in the customer’s timezone and updates related tests accordingly.
- Extracts timezone-aware
usage_datecalculation into a helper method in the service - Updates specs to include a customer timezone, refactors raw datetime strings, and adds a
#usage_dateunit test - Replaces direct
to_datecalls with the new helper throughout the service
Comments suppressed due to low confidence (1)
spec/services/daily_usages/fill_from_invoice_service_spec.rb:37
- [nitpick] The top-level
let(:usage_date)collides with thesubject(:usage_date)in the#usage_datetests. Consider renaming the first helper to something likeexpected_usage_datefor clarity.
let(:usage_date) do
vincent-pochet
approved these changes
Jul 3, 2025
e4fdb64 to
a06c145
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context `DailyUsages::FillFromInvoiceService` was not taking into account customer timezone when saving `usage_date`. For that reason the last day of the period was skipped in some cases. ## Description Fix usage_date in `DailyUsages::FillFromInvoiceService`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
DailyUsages::FillFromInvoiceServicewas not taking into account customer timezone when savingusage_date.For that reason the last day of the period was skipped in some cases.
Description
Fix usage_date in
DailyUsages::FillFromInvoiceService.