fix(payment_request): Prevent payment creation when invoices are payment succeeded #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jul 3, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…ent succeeded (#3910) ## Context When retrying a failed `PaymentRequests::Payments::CreateJob` (manually or automatically), we are not checking if the attached invoices are still ready for payment processing. This lead to a risk of duplicated payments. ## Description This pull request adds a new guard to the `PaymentRequests::Payments::CreateService` to early return when one of the invoice of the `PaymentRequest` is not flagged as `ready_for_payment_processing`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When retrying a failed
PaymentRequests::Payments::CreateJob(manually or automatically), we are not checking if the attached invoices are still ready for payment processing. This lead to a risk of duplicated payments.Description
This pull request adds a new guard to the
PaymentRequests::Payments::CreateServiceto early return when one of the invoice of thePaymentRequestis not flagged asready_for_payment_processing