feat(usages): Add is_customer_tin_empty argument to resolvers #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ea15c9 to
f4c2de3
Compare
There was a problem hiding this comment.
Pull Request Overview
Add a new is_customer_tin_empty argument across GraphQL schema definitions and resolver implementations so it can be passed through to the backend Data API.
- Introduced
isCustomerTinEmptyinschema.jsonandschema.graphqlfor multiple Query fields. - Added
argument :is_customer_tin_emptyin Ruby resolver classes underapp/graphql/resolvers. - Renamed
graphql_nameinAggregatedAmountsResolverto reflect aggregated usage amounts.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schema.json | Added isCustomerTinEmpty argument entries to GraphQL introspection schema |
| schema.graphql | Updated Query definitions to include isCustomerTinEmpty argument |
| app/graphql/resolvers/data_api/usages_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/data_api/usages/invoiced_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/data_api/usages/aggregated_amounts_resolver.rb | Added argument, renamed graphql_name, left description unchanged |
| app/graphql/resolvers/data_api/revenue_streams_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/data_api/prepaid_credits_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/data_api/mrrs_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/analytics/overdue_balances_resolver.rb | Added is_customer_tin_empty argument |
| app/graphql/resolvers/analytics/invoice_collections_resolver.rb | Added is_customer_tin_empty argument |
Comments suppressed due to low confidence (6)
app/graphql/resolvers/data_api/usages/aggregated_amounts_resolver.rb:13
- [nitpick] The description still refers to general usages; consider updating it to something like 'Query aggregated usage amounts of an organization' to match the renamed
graphql_name.
description "Query usages of an organization"
schema.graphql:8019
- [nitpick] Add a descriptive comment above
isCustomerTinEmptyin the SDL so API consumers understand what this flag controls.
dataApiMrrs(billingEntityCode: String, currency: CurrencyEnum, customerCountry: CountryCode, customerType: CustomerTypeEnum, externalCustomerId: String, externalSubscriptionId: String, fromDate: ISO8601Date, isCustomerTinEmpty: Boolean, planCode: String, timeGranularity: TimeGranularityEnum, toDate: ISO8601Date): DataApiMrrCollection!
app/graphql/resolvers/data_api/usages_resolver.rb:32
- [nitpick] Consider adding or updating tests to verify that
is_customer_tin_emptyis properly accepted and passed through by this resolver.
argument :is_customer_tin_empty, Boolean, required: false
app/graphql/resolvers/data_api/usages_resolver.rb:36
- The new
is_customer_tin_emptyargument is added but not forwarded to the Data API call. Ensure you includeargs[:is_customer_tin_empty]when invoking the backend client.
def resolve(**args)
app/graphql/resolvers/data_api/usages/invoiced_resolver.rb:39
- Make sure to pass
args[:is_customer_tin_empty]into the data API request inside this resolver, otherwise the flag will be ignored.
def resolve(**args)
app/graphql/resolvers/data_api/usages/aggregated_amounts_resolver.rb:36
- You’ve added the
is_customer_tin_emptyargument but haven’t forwarded it to the backend service. Update the resolve method to include this flag.
def resolve(**args)
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Description Add `is_customer_tin_empty` argument to GraphQL resolvers so that is can be passed to Data API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
is_customer_tin_emptyargument to GraphQL resolvers so that is can be passed to Data API.