fix(payments): Prevent returning non-persisted payment in stripe service #3916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…ice (#3916) ## Context Currently `PaymentRequests::Payments::StripeService` in certain conditions might return result with non-persisted payment on it. That creates issues in other services because they assume that payment is persisted if returned. Particularly, this [PaymentProviders::Stripe::Webhooks::PaymentIntentSucceededService](https://github.com/getlago/lago-api/blob/b643cac6e33e0106f40423fb02917107de802d94/app/services/payment_providers/stripe/webhooks/payment_intent_succeeded_service.rb#L6) service tries to enqueue job with not saved record causing `ActiveJob::SerializationError:` exception. ## Description Adjust service to avoid returning non-persisted payments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently
PaymentRequests::Payments::StripeServicein certain conditions might return result with non-persisted payment on it. That creates issues in other services because they assume that payment is persisted if returned.Particularly, this PaymentProviders::Stripe::Webhooks::PaymentIntentSucceededService service tries to enqueue job with not saved record causing
ActiveJob::SerializationError:exception.Description
Adjust service to avoid returning non-persisted payments