chore(matcher): Rename enqueue_after_commit matcher to have_enqueued_job_after_commit
#3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_job_after_commit` This is a small refactor to make the matcher closer to the `have_enqueued_job` matcher. This also update the `WalletTransactions::CreateFromParamsService` to rely on this matcher after the changes introduced in 4a5e510.
vincent-pochet
approved these changes
Jul 3, 2025
julienbourdeau
approved these changes
Jul 3, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…ed_job_after_commit` (#3909) ## Description This is a small refactor to make the matcher closer to the `have_enqueued_job` matcher and improve the error messages. This also update the `WalletTransactions::CreateFromParamsService` spec to rely on this matcher after the changes introduced in 4a5e510.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small refactor to make the matcher closer to the
have_enqueued_jobmatcher and improve the error messages.This also update the
WalletTransactions::CreateFromParamsServiceto rely on this matcher after the changes introduced in 4a5e510.