fix(progressive_billing): Avoid checking threshold on terminated subscriptions #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jul 1, 2025
It's a race condition:
We should not end in this situation anyway as the usage is supposed to be billed with the termination invoice |
|
Thanks for the explanation @vincent-pochet 🙏 |
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…criptions (#3893) ## Context We are receiving ` Idempotency::IdempotencyError` for progressive billing invoices generation on terminated subscriptions. ## Description We should not generate progressive billing invoices for terminated subscriptions as the usage will be billed anyway with the termination invoice. This PR simply adds a check on the subscription status before proceeding with the invoice generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are receiving
Idempotency::IdempotencyErrorfor progressive billing invoices generation on terminated subscriptions.Description
We should not generate progressive billing invoices for terminated subscriptions as the usage will be billed anyway with the termination invoice.
This PR simply adds a check on the subscription status before proceeding with the invoice generation.