fix(wallet_transaction): Ensure consistency when creating wallet transaction #3895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ffc5b1 to
5540344
Compare
vincent-pochet
added a commit
that referenced
this pull request
Jul 3, 2025
## Context This PR fixes a regression introduced by #3895 The wallet transaction processing was performed in a single database transaction. I the process a `BillPaidCreditJob` is enqueued. Since it's now in the DB transaction, it leads in some situation to an `ActiveJob::DeserializationError`. ## Description This PR fixes the situation by enqueuing the job after the the commit of the DB transaction
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…saction (#3895) ## Context An issue has been identifier on the `POST /v1/wallet_transactions` used to create a transaction on a wallet. In some situation if the same wallet is being refreshed in a separate process (job, parallel call to the endpoint), an `ActiveRecord::StaleObjectError` can be raised when running an update on the model. The main reason is that the wallet model is using an optimistic locking approach to avoid inconsistencies. The error is raised and it leads to an HTTP 500 response error returned by the API. An other problem appears here: the process to create the wallet transaction is not transactional, meaning that a wallet transaction might have been persisted in the database without impacting the wallet balance... ## Description This PR: - Wrap the logic in a single database transaction making sure nothing is persisted if something goes wrong in the process - Adds an auto retry logic when an `ActiveRecord::StaleObjectError` is raised
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context This PR fixes a regression introduced by #3895 The wallet transaction processing was performed in a single database transaction. I the process a `BillPaidCreditJob` is enqueued. Since it's now in the DB transaction, it leads in some situation to an `ActiveJob::DeserializationError`. ## Description This PR fixes the situation by enqueuing the job after the the commit of the DB transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An issue has been identifier on the
POST /v1/wallet_transactionsused to create a transaction on a wallet.In some situation if the same wallet is being refreshed in a separate process (job, parallel call to the endpoint), an
ActiveRecord::StaleObjectErrorcan be raised when running an update on the model. The main reason is that the wallet model is using an optimistic locking approach to avoid inconsistencies.The error is raised and it leads to an HTTP 500 response error returned by the API. An other problem appears here: the process to create the wallet transaction is not transactional, meaning that a wallet transaction might have been persisted in the database without impacting the wallet balance...
Description
This PR:
ActiveRecord::StaleObjectErroris raised