fix(aggregator): Add auto-retry logic on SSL error #3887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f809934 to
5569ca4
Compare
jdenquin
approved these changes
Jun 30, 2025
5569ca4 to
066a8df
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context Many calls to external aggregators are failing with errors like `OpenSSL::SSL::SSLError`, leading to a failure of caller service. Most of the time this error is just a transient "bad luck" error and can just be retries automatically. The Lago HTTP client is lacking the ability to retry the query automatically on this kind of error ## Description This PR adds a new `reties_on` keyword argument on the `LagoHttpClient` to allow us to define a list of error class that can be rescued and retried automatically. For now, it reties 3 times at most before re-raising the error, if it's not enough, we might extend this approach to allow us to define the number of retries for each type of error. This PR also plug this system in the base http_client of aggregator services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Many calls to external aggregators are failing with errors like
OpenSSL::SSL::SSLError, leading to a failure of caller service. Most of the time this error is just a transient "bad luck" error and can just be retries automatically.The Lago HTTP client is lacking the ability to retry the query automatically on this kind of error
Description
This PR adds a new
reties_onkeyword argument on theLagoHttpClientto allow us to define a list of error class that can be rescued and retried automatically.For now, it reties 3 times at most before re-raising the error, if it's not enough, we might extend this approach to allow us to define the number of retries for each type of error.
This PR also plug this system in the base http_client of aggregator services