misc(pricing-units): Various adjustments #3874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jun 27, 2025
vincent-pochet
approved these changes
Jun 27, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context Adjust implementation based on QA. ## Description Limit `short_name` to 3 chars max Change pricing units order to `name` ASC, `created_at` DESC Add support for conversion rate override during subscription creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adjust implementation based on QA.
Description
Limit
short_nameto 3 chars maxChange pricing units order to
nameASC,created_atDESCAdd support for conversion rate override during subscription creation