Fix: process cascade charge creation in batches #3864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
approved these changes
Jun 26, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 30, 2025
## Context Lago client has issues when passing new charge to 30k child charges. ## Description Instead of using one job to handle all children changes, this PR creates batches of 100 records where one batch is processed in one background job. Having individual jobs for each child charge also didn't work since too many jobs could be scheduled at the same time and it can lead to OOM issues with redis, depending on the load at that particular moment.
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context Lago client has issues when passing new charge to 30k child charges. ## Description Instead of using one job to handle all children changes, this PR creates batches of 100 records where one batch is processed in one background job. Having individual jobs for each child charge also didn't work since too many jobs could be scheduled at the same time and it can lead to OOM issues with redis, depending on the load at that particular moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Lago client has issues when passing new charge to 30k child charges.
Description
Instead of using one job to handle all children changes, this PR creates batches of 100 records where one batch is processed in one background job.
Having individual jobs for each child charge also didn't work since too many jobs could be scheduled at the same time and it can lead to OOM issues with redis, depending on the load at that particular moment.