misc(clickhouse): Rewrite aggregation queries using Arel #3858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bb53c0 to
1d0b7b7
Compare
1d0b7b7 to
c85b31f
Compare
jdenquin
approved these changes
Jun 20, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jun 27, 2025
## Context This PR follows #3858 ## Description It applies the same refactor to Unique Count and Weigtehd Sum aggregations queries that are built in different services
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context After some investigation in our quest to improve performances with Clickhouse database, it was found that in some condition, when computing events aggregation, many requests where sent to the Clickhouse cluster only to retrieve the tables structures. This is happening specifically when calling `to_sql` on some queries built using `ActiveRecord`. These queries are not long to process but they uses some processor time on the cluster and as such cost money to Lago and slow down the aggregation processing especially when the cluster is under heavy load. ## Description As these queries can be easily avoided as they are not required for the aggregation, since the result relies only on a aggregated values rather than on a list of record, the decision was made to refactor the `Events::Stores::ClickhouseStore` to avoid using `to_sql` when writing queries and to rely as much as possible on pure SQL. To keep the ability to combine conditions and select, the rework was made using `Arel` to rewrite the queries.
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context This PR follows #3858 ## Description It applies the same refactor to Unique Count and Weigtehd Sum aggregations queries that are built in different services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After some investigation in our quest to improve performances with Clickhouse database, it was found that in some condition, when computing events aggregation, many requests where sent to the Clickhouse cluster only to retrieve the tables structures.
This is happening specifically when calling
to_sqlon some queries built usingActiveRecord.These queries are not long to process but they uses some processor time on the cluster and as such cost money to Lago and slow down the aggregation processing especially when the cluster is under heavy load.
Description
As these queries can be easily avoided as they are not required for the aggregation, since the result relies only on a aggregated values rather than on a list of record, the decision was made to refactor the
Events::Stores::ClickhouseStoreto avoid usingto_sqlwhen writing queries and to rely as much as possible on pure SQL.To keep the ability to combine conditions and select, the rework was made using
Arelto rewrite the queries.