misc(clickhouse): Add retries on to_sql #3855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdenquin
approved these changes
Jun 20, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context This PR follows #3733 but we are still seeing some `Errno::ECONNRESET Connection reset by peer - SSL_connect` ## Description It refactors a bit the way we handle retries as it appears that some `events.to_sql` are also hiting the database. NOTE: this is a quick fix, a future PR will had some logic to rewrite theses queries in pure SQL to reduce this unintended queries that generates some load on the clickhouse instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follows #3733 but we are still seeing some
Errno::ECONNRESET Connection reset by peer - SSL_connectDescription
It refactors a bit the way we handle retries as it appears that some
events.to_sqlare also hiting the database.NOTE: this is a quick fix, a future PR will had some logic to rewrite theses queries in pure SQL to reduce this unintended queries that generates some load on the clickhouse instance