Skip to content

Reapply "chore(db): Squash old migrations into a single file" (#3839) #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

vincent-pochet
Copy link
Collaborator

Reapply #3839 that was rollbacked to allow a non blocking release

Context

As we are planing to release the "not null organization" pull request, it was decided to take this as an opportunity to squash the old database migration into a single migration file, to reduce the number of migrations.

Related to #3829

Description

Lago version 1.20.0 was used as a reference to squash the migrations.

  • All migrations from previous versions are merged in a single InitialMigration migration file.
    • It uses the SQL format to preserve the orders and make sure the migration test workflow continue to pass on Github no matter if the structure comes from previous migrations or from this file.
    • It reuse the previous last migration version 20250122112050 to make sure it will not be executed on instance running v1.20.0 or later.
    • It adds a small check to fail running the migration if an upgrade is made from a version prior to 1.20.0 to the bridge release containing this change
  • All squashed migrations files are removed

@vincent-pochet vincent-pochet force-pushed the reapply-migration-squash branch 2 times, most recently from 82f5639 to 41c49f8 Compare June 26, 2025 07:10
@vincent-pochet vincent-pochet force-pushed the reapply-migration-squash branch from 41c49f8 to bcf4ea2 Compare June 26, 2025 08:25
@vincent-pochet vincent-pochet merged commit 4025d4f into main Jun 26, 2025
14 checks passed
@vincent-pochet vincent-pochet deleted the reapply-migration-squash branch June 26, 2025 08:29
diegocharles pushed a commit that referenced this pull request Jun 30, 2025
…#3842)

Reapply #3839 that was
rollbacked to allow a non blocking release

## Context

As we are planing to release the ["not null organization" pull
request](#3687), it was decided
to take this as an opportunity to squash the old database migration into
a single migration file, to reduce the number of migrations.

Related to #3829

## Description

Lago version 1.20.0 was used as a reference to squash the migrations.

- All migrations from previous versions are merged in a single
`InitialMigration` migration file.
- It uses the SQL format to preserve the orders and make sure the
migration test workflow continue to pass on Github no matter if the
structure comes from previous migrations or from this file.
- It reuse the previous last migration version `20250122112050` to make
sure it will not be executed on instance running v1.20.0 or later.
- It adds a small check to fail running the migration if an upgrade is
made from a version prior to 1.20.0 to the bridge release containing
this change
- All squashed migrations files are removed
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
…#3842)

Reapply #3839 that was
rollbacked to allow a non blocking release

## Context

As we are planing to release the ["not null organization" pull
request](#3687), it was decided
to take this as an opportunity to squash the old database migration into
a single migration file, to reduce the number of migrations.

Related to #3829

## Description

Lago version 1.20.0 was used as a reference to squash the migrations.

- All migrations from previous versions are merged in a single
`InitialMigration` migration file.
- It uses the SQL format to preserve the orders and make sure the
migration test workflow continue to pass on Github no matter if the
structure comes from previous migrations or from this file.
- It reuse the previous last migration version `20250122112050` to make
sure it will not be executed on instance running v1.20.0 or later.
- It adds a small check to fail running the migration if an upgrade is
made from a version prior to 1.20.0 to the bridge release containing
this change
- All squashed migrations files are removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants