Reapply "chore(organization): Not null organization_id" (#3838) #3841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jun 19, 2025
1d30f46 to
43de0bd
Compare
This reverts commit 890fe66.
43de0bd to
ab2c954
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jun 30, 2025
Reapply #3838 that was rollbacked to allow a non blocking release ## Context This PR is part of the epic to add `organization_id` on all tables of the application ## Description The current one is removing the `optional` attribute on all `belongs_to :organization` relations. In a next step the presence will be enforced at database level with a not null constraint The PR also updates the relations from customer and organization table to make sure it uses the organization_id column. **NOTE**: Since this change will require all tables to be updated before the release, a migration guide will be added (See https://getlago.com/docs/guide/migration/migration-to-v1.29.0 as an example). The guide will state that customer will have to first run the [migrations:fill_organization_id rake task](https://github.com/getlago/lago-api/blob/main/lib/tasks/migrations/organization_id.rake)
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
Reapply #3838 that was rollbacked to allow a non blocking release ## Context This PR is part of the epic to add `organization_id` on all tables of the application ## Description The current one is removing the `optional` attribute on all `belongs_to :organization` relations. In a next step the presence will be enforced at database level with a not null constraint The PR also updates the relations from customer and organization table to make sure it uses the organization_id column. **NOTE**: Since this change will require all tables to be updated before the release, a migration guide will be added (See https://getlago.com/docs/guide/migration/migration-to-v1.29.0 as an example). The guide will state that customer will have to first run the [migrations:fill_organization_id rake task](https://github.com/getlago/lago-api/blob/main/lib/tasks/migrations/organization_id.rake)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #3838 that was rollbacked to allow a non blocking release
Context
This PR is part of the epic to add
organization_idon all tables of the applicationDescription
The current one is removing the
optionalattribute on allbelongs_to :organizationrelations. In a next step the presence will be enforced at database level with a not null constraintThe PR also updates the relations from customer and organization table to make sure it uses the organization_id column.
NOTE: Since this change will require all tables to be updated before the release, a migration guide will be added (See https://getlago.com/docs/guide/migration/migration-to-v1.29.0 as an example). The guide will state that customer will have to first run the migrations:fill_organization_id rake task