feat: Generate credit note validate License #3848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
approved these changes
Jun 19, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context
Voiding an invoice with the [generate_credit_note]
flag should be exclusive to organizations on a Premium license.
Prior to this change, non-premium tenants could still try to generate
credit notes through the void-invoice path, bypassing licensing rules
this would lead to a 500 error on the server
## Description
Added a guard clause in `Invoices::VoidService#call`:
```ruby
def generate_credit_note_allowed?
return true unless generate_credit_note # nothing requested
License.premium? # licence check
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Voiding an invoice with the [generate_credit_note]
flag should be exclusive to organizations on a Premium license.
Prior to this change, non-premium tenants could still try to generate credit notes through the void-invoice path, bypassing licensing rules this would lead to a 500 error on the server
Description
Added a guard clause in
Invoices::VoidService#call: