fix(customer): Fix email validation and add tests #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current email validation regex is too permissive, allowing invalid emails like `test email@domain.com`. This caused some invoice emails sendout failures. The main issue comes from the fact that our regex does not have `\A` and `\z` anchors, which means it can match parts of a string rather than the whole string.
ivannovosad
approved these changes
Jun 25, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 30, 2025
## Context Our current email validation regex is too permissive, allowing invalid emails like `test email@domain.com`. This caused some invoice email send-out failures. ## Description The main issue comes from the fact that our regex does not have `\A` and `\z` anchors, which means it can match parts of a string rather than the whole string. The validator also accepted a trailing `,`. To ensure no breaking change on potential invalid emails, the validation now only runs if customer's email was changed.
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context Our current email validation regex is too permissive, allowing invalid emails like `test email@domain.com`. This caused some invoice email send-out failures. ## Description The main issue comes from the fact that our regex does not have `\A` and `\z` anchors, which means it can match parts of a string rather than the whole string. The validator also accepted a trailing `,`. To ensure no breaking change on potential invalid emails, the validation now only runs if customer's email was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our current email validation regex is too permissive, allowing invalid emails like
test email@domain.com. This caused some invoice email send-out failures.Description
The main issue comes from the fact that our regex does not have
\Aand\zanchors, which means it can match parts of a string rather than the whole string. The validator also accepted a trailing,.To ensure no breaking change on potential invalid emails, the validation now only runs if customer's email was changed.