chore(sidekiq): Update liveness socket to listen to 0.0.0.0 #3831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Sidekiq liveness socket configuration to bind to 0.0.0.0 instead of localhost, thereby allowing the service to listen on all network interfaces.
- Changed the TCPServer binding from "localhost" to "0.0.0.0" to improve liveness monitoring in environments where external access is required.
- Modified the configuration in config/initializers/sidekiq.rb.
Comments suppressed due to low confidence (1)
config/initializers/sidekiq.rb:35
- Binding the liveness server to 0.0.0.0 may expose it publicly. Please ensure that proper network restrictions (e.g., firewall rules) or access controls are in place to prevent unauthorized access.
server = TCPServer.new("0.0.0.0", LIVENESS_PORT)
groyoh
approved these changes
Jun 16, 2025
|
Side note: @jdenquin we should probably make the liveliness port configurable at some point. |
rsempe
approved these changes
Jun 16, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
- Improve sidekiq liveness socket to listen to `0.0.0.0` instead of localhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.0.0instead of localhost