fix(dates): Fix validation of impossible dates #3821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
floganz
reviewed
Jun 12, 2025
aa2ed09 to
3740107
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the validation of dates by improving the Common#valid_date? method to correctly handle impossible dates.
- Updated the date validation logic in Common#valid_date? to catch Date::Error exceptions.
- Enhanced test coverage in common_spec.rb to verify behavior for both valid and invalid date strings.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/controllers/concerns/common_spec.rb | Added tests for valid, malformed, and impossible dates. |
| app/controllers/concerns/common.rb | Replaced Date._strptime with Date.strptime and added exception handling to improve date validation. |
Comments suppressed due to low confidence (1)
app/controllers/concerns/common.rb:11
- Consider including a format string in the Date.strptime call for clarity and to ensure consistency in date parsing (e.g., Date.strptime(date, '%Y-%m-%d')).
Date.strptime(date)
vincent-pochet
approved these changes
Jun 12, 2025
floganz
approved these changes
Jun 12, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context It was possible to call `GET /api/v1/invoices` API endpoint with impossible `issuing_date_from`, `issuing_date_to` params e.g.: `2025-02-30` ## Description Fix the validation method: `Common#valid_date?`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It was possible to call
GET /api/v1/invoicesAPI endpoint with impossibleissuing_date_from,issuing_date_toparams e.g.:2025-02-30Description
Fix the validation method:
Common#valid_date?