chore(optimization): remove n+1 query from invoices controller #3827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
approved these changes
Jun 13, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context We’ve been seeing Sentry EU alerts related to N+1 queries when serializing invoices. This PR addresses one of those issues: [Sentry Issue #44595609](https://lago-eu.sentry.io/issues/44595609/?project=4508291321233488&query=is%3Aunresolved&referrer=issue-stream&stream_index=3) ## Description Updated the render call to eager load additional associations for invoices. This change ensures that billing_entity and applied_usage_thresholds are preloaded when rendering the collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We’ve been seeing Sentry EU alerts related to N+1 queries when serializing invoices.
This PR addresses one of those issues:
Sentry Issue #44595609
Description
Updated the render call to eager load additional associations for invoices.
This change ensures that billing_entity and applied_usage_thresholds are preloaded when rendering the collection.