fix(no-customer-on-payment):early return when payment method has no c… #3826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3caeeab to
fda6854
Compare
fda6854 to
ce28e4b
Compare
groyoh
approved these changes
Jun 19, 2025
app/services/payment_providers/stripe/webhooks/setup_intent_succeeded_service.rb
Show resolved
Hide resolved
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
#3826) Whenever we have a `setup_intent.succeeded` with a payment method that has no customer attached to it. Stripe does that when setting up payment methods that has some problems (we don't know exactly which problems are). The `setup_intent.succeeded` and `payment_method.detached` are fired almost at the same time. [Once `payment_method.detached` the payment method becomes unusable. ](https://docs.stripe.com/api/payment_methods/detach) This raises on `app/services/payment_providers/stripe/webhooks/setup_intent_succeeded_service.rb` ``` Stripe::InvalidRequestError: The customer does not have a payment method with the ID <pm_ID>. The payment method must be attached to the customer. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we have a
setup_intent.succeededwith a payment method that has no customer attached to it.Stripe does that when setting up payment methods that has some problems (we don't know exactly which problems are). The
setup_intent.succeededandpayment_method.detachedare fired almost at the same time.Once
payment_method.detachedthe payment method becomes unusable.This raises on
app/services/payment_providers/stripe/webhooks/setup_intent_succeeded_service.rb