feat(alerting): Serialize customer_external_id to TriggeredAlerts
#3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jun 12, 2025
floganz
approved these changes
Jun 12, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…3819) A TriggeredAlert is saved to DB when the current usage of the subscription crosses an alerting thresholds. It's sent over webhooks (serialized once and saved to `webhooks.payload` column). There is no API or graphql resolver to access triggered alerts. This adds 2 queries to the serialization. Nowhere in the code we serialize multiple triggered alert, so no "eager load" to edit. This is done to help customer easily retrieve the customer to warn. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TriggeredAlert is saved to DB when the current usage of the subscription crosses an alerting thresholds.
It's sent over webhooks (serialized once and saved to
webhooks.payloadcolumn). There is no API or graphql resolver to access triggered alerts.This adds 2 queries to the serialization. Nowhere in the code we serialize multiple triggered alert, so no "eager load" to edit.
This is done to help customer easily retrieve the customer to warn.