fix(subscriptions): Fix subscriptions creation race condition #3809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a database lock around subscription creation to prevent duplicate records under concurrent requests.
- Wraps currency update and subscription handling in a
customer.with_lockblock - Refreshes
@current_subscriptioninside the lock to avoid stale reads - Nested the lock inside an existing transaction
Comments suppressed due to low confidence (2)
app/services/subscriptions/create_service.rb:35
- [nitpick]
with_lockalready starts its own transaction. You may be able to remove the explicitActiveRecord::Base.transactionwrapper to simplify nested transaction handling.
ActiveRecord::Base.transaction do
app/services/subscriptions/create_service.rb:41
- [nitpick] Add or update specs that simulate concurrent
POST /api/v1/subscriptionsrequests to verify that only one subscription record is created under race conditions.
# Refresh current_subscription inside the lock to avoid stale data
31411c7 to
c2c9d6a
Compare
c2c9d6a to
dbbf14c
Compare
julienbourdeau
approved these changes
Jun 10, 2025
rsempe
pushed a commit
that referenced
this pull request
Jun 11, 2025
## Context There was a possible race condition when calling this API endpoint multiple times with the same `plan_code`: ``` POST /api/v1/subscriptions ``` Duplicate subscriptions were created ## Description Add lock to customer to `Subscriptions::CreateService`
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context There was a possible race condition when calling this API endpoint multiple times with the same `plan_code`: ``` POST /api/v1/subscriptions ``` Duplicate subscriptions were created ## Description Add lock to customer to `Subscriptions::CreateService`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There was a possible race condition when calling this API endpoint multiple times with the same
plan_code:Duplicate subscriptions were created
Description
Add lock to customer to
Subscriptions::CreateService