fix(webhooks): Fix sending of invoice.payment_status_updated webhook on manual payment recording
#3795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
Jun 6, 2025
|
Thanks @rsempe @julienbourdeau 🙏 |
…k on manual payment recording We didn't send the `invoice.payment_status_updated` webhook if a manual payment is recorded on an invoice and the payment status is updated. Steps to reproduce: 1. Find an overdue invoice. 2. Select the "record a payment" option. 3. Record a payment for the amount of the overdue invoice (this changes the payment status to "succeeded"). 4. No webhook is triggered.
a487578 to
c9cc664
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…k on manual payment (#3795) ## Context We didn't send the `invoice.payment_status_updated` webhook if a manual payment is recorded on an invoice and the payment status is updated. Steps to reproduce: 1. Find an overdue invoice. 2. Select the "record a payment" option. 3. Record a payment for the amount of the overdue invoice (this changes the payment status to "succeeded"). 4. No webhook is triggered. ## Description This commit fixes sending of `invoice.payment_status_updated` webhook on manual payment recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We didn't send the
invoice.payment_status_updatedwebhook if a manual payment is recorded on an invoice and the payment status is updated.Steps to reproduce:
Description
This PR fixes sending of
invoice.payment_status_updatedwebhook on manual payment recording.