fix(filter): Matching in advance events with ALL_FILTER_VALUES #3772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Jun 10, 2025
88f3aa5 to
2b7d366
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Description
This PR fixes the in advance filter matching for filters defined using
the `ALL_FILTER_VALUES`
Today if a filter is defined with the following structure
```json
{
"scheme": ["visa", "mastercard"],
"card_type": ["__ALL_FILTER_VALUES__"]
}
```
it should match an event sent with the following properties: `{"scheme":
"visa", "card_type": "debit" }` but it's not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the in advance filter matching for filters defined using the
ALL_FILTER_VALUESToday if a filter is defined with the following structure
{ "scheme": ["visa", "mastercard"], "card_type": ["__ALL_FILTER_VALUES__"] }it should match an event sent with the following properties:
{"scheme": "visa", "card_type": "debit" }but it's not