feat(usage): Fix history usages #3770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with incorrect daily usage calculations by adjusting the boundaries in two services.
- In FillHistoryService, the time freezing logic is updated to ensure the correct day is captured.
- In FillFromInvoiceService, the service now uses charge-specific datetime fields to accurately define usage boundaries.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/services/daily_usages/fill_history_service.rb | Updates the time freeze logic to better capture the intended usage day |
| app/services/daily_usages/fill_from_invoice_service.rb | Updates boundaries using charges_from_datetime and charges_to_datetime for correct historical usage calculation |
Comments suppressed due to low confidence (1)
app/services/daily_usages/fill_history_service.rb:23
- [nitpick] Consider renaming the variable 'ds' to a more descriptive name (e.g., 'dates_service') to improve readability and maintainability.
ds = Subscriptions::DatesService.new_instance(subscription, date, current_usage: true)
vincent-pochet
approved these changes
Jun 2, 2025
julienbourdeau
approved these changes
Jun 2, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 2, 2025
## Context The service calculating historical daily usages used to jump to the next period in case of calculating usages for the last day of current period. ## Description - Fix the incorrect day of usages in `FillHistoryService` - Fix incorrect boundaries in `FillFromInvoiceService`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The service calculating historical daily usages used to jump to the next period in case of calculating usages for the last day of current period.
Description
FillHistoryServiceFillFromInvoiceService