chore(spec): better scenario helpers #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cd4607 to
ed05fc3
Compare
ed05fc3 to
81f687c
Compare
julienbourdeau
commented
May 28, 2025
rsempe
approved these changes
May 28, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 2, 2025
As I'm working on scenario tests, I realize there are some issues with the helpers: * I always hated that api call helpers didn't return the http call response. * Also, some helpers didn't empty the queue so the behavior is "incorrect".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm working on scenario tests, I realize there are some issues with the helpers: