Activity log fixes #3757
Merged
Activity log fixes #3757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
May 30, 2025
rsempe
pushed a commit
that referenced
this pull request
May 30, 2025
Some fixes for the Activity Logs. ``` "billable_metric.created" => OK "billable_metric.updated" => OK "billable_metric.deleted" => OK "plan.created" => OK "plan.updated" => OK "plan.deleted" => OK "customer.created" => OK "customer.updated" => OK "customer.deleted" => OK "invoice.drafted" "invoice.failed" "invoice.created" "invoice.one_off_created" => FIXED OK "invoice.paid_credit_added" "invoice.generated" => OK "invoice.payment_status_updated" => OK "invoice.payment_overdue" "invoice.voided" => OK "invoice.payment_failure" "payment_receipt.created" => FIXED OK / *** PaymentReceipt does not have a customer associated "payment_receipt.generated" => FIXED OK / *** same as "payment_receipt.created" "credit_note.created" => OK "credit_note.generated" => OK "credit_note.refund_failure" => FIXED OK "billing_entities.created" "billing_entities.updated" "billing_entities.deleted" => NOT IMPLEMENTED "subscription.started" => OK "subscription.terminated" => FIXED OK "subscription.updated" => OK "wallet.created" => OK / *** Front has to fix ".id" to use ".lago_id" or use wallet ".name" "wallet.updated" => OK / *** same as "wallet.created" "wallet_transaction.payment_failure" "wallet_transaction.created" => OK / *** same as "wallet.created" "wallet_transaction.updated" => FIXED OK / *** same as "wallet.created" "payment.recorded" => FIXED OK / *** The activity_object is a Payment. Resouce can be an Invoice or PaymentRequest. Front expects to activity_object to have "invoice_number". "coupon.created" => OK "coupon.updated" => OK "coupon.deleted" => OK / *** Maybe add "coupon.terminated" ? "applied_coupon.created" => OK / *** Front is broken, it expects activity_object have ".code" but its ".coupon_code" "applied_coupon.deleted" => OK / *** same as "applied_coupon.created" ```
rsempe
pushed a commit
that referenced
this pull request
May 30, 2025
Some fixes for the Activity Logs. ``` "billable_metric.created" => OK "billable_metric.updated" => OK "billable_metric.deleted" => OK "plan.created" => OK "plan.updated" => OK "plan.deleted" => OK "customer.created" => OK "customer.updated" => OK "customer.deleted" => OK "invoice.drafted" "invoice.failed" "invoice.created" "invoice.one_off_created" => FIXED OK "invoice.paid_credit_added" "invoice.generated" => OK "invoice.payment_status_updated" => OK "invoice.payment_overdue" "invoice.voided" => OK "invoice.payment_failure" "payment_receipt.created" => FIXED OK / *** PaymentReceipt does not have a customer associated "payment_receipt.generated" => FIXED OK / *** same as "payment_receipt.created" "credit_note.created" => OK "credit_note.generated" => OK "credit_note.refund_failure" => FIXED OK "billing_entities.created" "billing_entities.updated" "billing_entities.deleted" => NOT IMPLEMENTED "subscription.started" => OK "subscription.terminated" => FIXED OK "subscription.updated" => OK "wallet.created" => OK / *** Front has to fix ".id" to use ".lago_id" or use wallet ".name" "wallet.updated" => OK / *** same as "wallet.created" "wallet_transaction.payment_failure" "wallet_transaction.created" => OK / *** same as "wallet.created" "wallet_transaction.updated" => FIXED OK / *** same as "wallet.created" "payment.recorded" => FIXED OK / *** The activity_object is a Payment. Resouce can be an Invoice or PaymentRequest. Front expects to activity_object to have "invoice_number". "coupon.created" => OK "coupon.updated" => OK "coupon.deleted" => OK / *** Maybe add "coupon.terminated" ? "applied_coupon.created" => OK / *** Front is broken, it expects activity_object have ".code" but its ".coupon_code" "applied_coupon.deleted" => OK / *** same as "applied_coupon.created" ```
rsempe
pushed a commit
that referenced
this pull request
Jun 2, 2025
Some fixes for the Activity Logs. ``` "billable_metric.created" => OK "billable_metric.updated" => OK "billable_metric.deleted" => OK "plan.created" => OK "plan.updated" => OK "plan.deleted" => OK "customer.created" => OK "customer.updated" => OK "customer.deleted" => OK "invoice.drafted" "invoice.failed" "invoice.created" "invoice.one_off_created" => FIXED OK "invoice.paid_credit_added" "invoice.generated" => OK "invoice.payment_status_updated" => OK "invoice.payment_overdue" "invoice.voided" => OK "invoice.payment_failure" "payment_receipt.created" => FIXED OK / *** PaymentReceipt does not have a customer associated "payment_receipt.generated" => FIXED OK / *** same as "payment_receipt.created" "credit_note.created" => OK "credit_note.generated" => OK "credit_note.refund_failure" => FIXED OK "billing_entities.created" "billing_entities.updated" "billing_entities.deleted" => NOT IMPLEMENTED "subscription.started" => OK "subscription.terminated" => FIXED OK "subscription.updated" => OK "wallet.created" => OK / *** Front has to fix ".id" to use ".lago_id" or use wallet ".name" "wallet.updated" => OK / *** same as "wallet.created" "wallet_transaction.payment_failure" "wallet_transaction.created" => OK / *** same as "wallet.created" "wallet_transaction.updated" => FIXED OK / *** same as "wallet.created" "payment.recorded" => FIXED OK / *** The activity_object is a Payment. Resouce can be an Invoice or PaymentRequest. Front expects to activity_object to have "invoice_number". "coupon.created" => OK "coupon.updated" => OK "coupon.deleted" => OK / *** Maybe add "coupon.terminated" ? "applied_coupon.created" => OK / *** Front is broken, it expects activity_object have ".code" but its ".coupon_code" "applied_coupon.deleted" => OK / *** same as "applied_coupon.created" ```
rsempe
pushed a commit
that referenced
this pull request
Jun 2, 2025
Some fixes for the Activity Logs. ``` "billable_metric.created" => OK "billable_metric.updated" => OK "billable_metric.deleted" => OK "plan.created" => OK "plan.updated" => OK "plan.deleted" => OK "customer.created" => OK "customer.updated" => OK "customer.deleted" => OK "invoice.drafted" "invoice.failed" "invoice.created" "invoice.one_off_created" => FIXED OK "invoice.paid_credit_added" "invoice.generated" => OK "invoice.payment_status_updated" => OK "invoice.payment_overdue" "invoice.voided" => OK "invoice.payment_failure" "payment_receipt.created" => FIXED OK / *** PaymentReceipt does not have a customer associated "payment_receipt.generated" => FIXED OK / *** same as "payment_receipt.created" "credit_note.created" => OK "credit_note.generated" => OK "credit_note.refund_failure" => FIXED OK "billing_entities.created" "billing_entities.updated" "billing_entities.deleted" => NOT IMPLEMENTED "subscription.started" => OK "subscription.terminated" => FIXED OK "subscription.updated" => OK "wallet.created" => OK / *** Front has to fix ".id" to use ".lago_id" or use wallet ".name" "wallet.updated" => OK / *** same as "wallet.created" "wallet_transaction.payment_failure" "wallet_transaction.created" => OK / *** same as "wallet.created" "wallet_transaction.updated" => FIXED OK / *** same as "wallet.created" "payment.recorded" => FIXED OK / *** The activity_object is a Payment. Resouce can be an Invoice or PaymentRequest. Front expects to activity_object to have "invoice_number". "coupon.created" => OK "coupon.updated" => OK "coupon.deleted" => OK / *** Maybe add "coupon.terminated" ? "applied_coupon.created" => OK / *** Front is broken, it expects activity_object have ".code" but its ".coupon_code" "applied_coupon.deleted" => OK / *** same as "applied_coupon.created" ```
rsempe
pushed a commit
that referenced
this pull request
Jun 4, 2025
Some fixes for the Activity Logs. ``` "billable_metric.created" => OK "billable_metric.updated" => OK "billable_metric.deleted" => OK "plan.created" => OK "plan.updated" => OK "plan.deleted" => OK "customer.created" => OK "customer.updated" => OK "customer.deleted" => OK "invoice.drafted" "invoice.failed" "invoice.created" "invoice.one_off_created" => FIXED OK "invoice.paid_credit_added" "invoice.generated" => OK "invoice.payment_status_updated" => OK "invoice.payment_overdue" "invoice.voided" => OK "invoice.payment_failure" "payment_receipt.created" => FIXED OK / *** PaymentReceipt does not have a customer associated "payment_receipt.generated" => FIXED OK / *** same as "payment_receipt.created" "credit_note.created" => OK "credit_note.generated" => OK "credit_note.refund_failure" => FIXED OK "billing_entities.created" "billing_entities.updated" "billing_entities.deleted" => NOT IMPLEMENTED "subscription.started" => OK "subscription.terminated" => FIXED OK "subscription.updated" => OK "wallet.created" => OK / *** Front has to fix ".id" to use ".lago_id" or use wallet ".name" "wallet.updated" => OK / *** same as "wallet.created" "wallet_transaction.payment_failure" "wallet_transaction.created" => OK / *** same as "wallet.created" "wallet_transaction.updated" => FIXED OK / *** same as "wallet.created" "payment.recorded" => FIXED OK / *** The activity_object is a Payment. Resouce can be an Invoice or PaymentRequest. Front expects to activity_object to have "invoice_number". "coupon.created" => OK "coupon.updated" => OK "coupon.deleted" => OK / *** Maybe add "coupon.terminated" ? "applied_coupon.created" => OK / *** Front is broken, it expects activity_object have ".code" but its ".coupon_code" "applied_coupon.deleted" => OK / *** same as "applied_coupon.created" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for the Activity Logs.