-
Notifications
You must be signed in to change notification settings - Fork 125
feat(multientities): Update Invoice custom sections services #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ancorcruz
merged 21 commits into
main
from
feat/multientities/invoice_custom_sections_serv
May 29, 2025
Merged
feat(multientities): Update Invoice custom sections services #3742
ancorcruz
merged 21 commits into
main
from
feat/multientities/invoice_custom_sections_serv
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create records in the new table from the old selections table.
create records in the new table from the old selections table.
it works with the new join model
... to billing entities scope, as invoice custom sections are not applied to billing entities instead of organizaitons
to call the right services and use the new relationships
it is needed to migrate data... we will remove it later.
in replacement of "selected_for_organization"
annvelents
reviewed
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 👏
That's awesome!
And a lot of work!!!!
wow!!!!
Looks amazing, left couple comments
app/services/billing_entities/deselect_invoice_custom_section_service.rb
Show resolved
Hide resolved
annvelents
approved these changes
May 28, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 2, 2025
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/support-billing-from-multiple-entities ## Context Users who invoice the same products across multiple entities face the challenge of managing separate Lago organizations. This requires duplicating all billable metrics, plans, and setup, while also implementing additional logic to handle two different API keys and ensure the correct one is used for each affiliated entity. This process adds complexity and overhead to their billing operations. ## Description This change updates all services related to invoice custom sections in order to work with the new "applied" invoice custom sections relationships and replaces the application/selection of invoice custom section from organization level to billing entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/support-billing-from-multiple-entities
Context
Users who invoice the same products across multiple entities face the challenge of managing separate Lago organizations.
This requires duplicating all billable metrics, plans, and setup, while also implementing additional logic to handle two different API keys and ensure the correct one is used for each affiliated entity. This process adds complexity and overhead to their billing operations.
Description
This change updates all services related to invoice custom sections in order to work with the new "applied" invoice custom sections relationships and replaces the application/selection of invoice custom section from organization level to billing entities.