Skip to content

Conversation

vincent-pochet
Copy link
Collaborator

Description

This PR adds some missing validations on the Coupon model

It includes

  • status
  • expiration
  • coupon_type
  • frequency

Copy link
Collaborator

@rsempe rsempe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@vincent-pochet vincent-pochet merged commit 430019b into main May 30, 2025
14 checks passed
@vincent-pochet vincent-pochet deleted the fix-add-coupon-enum-validation branch May 30, 2025 10:07
diegocharles pushed a commit that referenced this pull request Jun 2, 2025
## Description

This PR adds some missing validations on the `Coupon` model

It includes
- status
- expiration
-  coupon_type
- frequency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants