Skip to content

fix(alerting): small QA return #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

fix(alerting): small QA return #3735

merged 1 commit into from
May 27, 2025

Conversation

julienbourdeau
Copy link
Contributor

  • Use error code value_already_exist instead of value_already_exists
  • fix problem where recurring threshold has the same value as non-recurring threshold

@julienbourdeau julienbourdeau self-assigned this May 27, 2025
@julienbourdeau julienbourdeau merged commit 73f18bc into main May 27, 2025
14 checks passed
@julienbourdeau julienbourdeau deleted the fix/alerting-qa branch May 27, 2025 09:48
groyoh added a commit that referenced this pull request Jul 4, 2025
@groyoh
fix(specs): Add a check to fail if community PR
c193d5b 
Currently, if a community PR is opened, the specs will not run because the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret will not be set. This will cause the specs to silently fail on the CI and potentially break `main`:

```
Run bundle exec rake knapsack_pro:queue:rspec
E, [2025-07-02T09:39:24.571116 #3735] ERROR -- : [knapsack_pro] {"errors" => ["invalid test suite token"]}

Finished in 0.45262 seconds (files took 5.69 seconds to load)
0 examples, 0 failures

E, [2025-07-02T09:39:24.572334 #3735] ERROR -- : [knapsack_pro] An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMethodError: undefined method 'response' for an instance of KnapsackPro::Client::Connection>
E, [2025-07-02T09:39:24.572368 #3735] ERROR -- : [knapsack_pro] Exception message: undefined method 'response' for an instance of KnapsackPro::Client::Connection
E, [2025-07-02T09:39:24.572463 #3735] ERROR -- : [knapsack_pro] Exception backtrace: /home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:12:in 'KnapsackPro::QueueAllocator::Batch#initialize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'Class#new'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'KnapsackPro::QueueAllocator#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:47:in 'KnapsackPro::QueueAllocator#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/base_runner.rb:29:in 'KnapsackPro::Runners::Queue::BaseRunner#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:181:in 'KnapsackPro::Runners::Queue::RSpecRunner#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:82:in 'block in KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
<internal:kernel>:168:in 'Kernel#loop'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:80:in 'KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:93:in 'block (2 levels) in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/configuration.rb:2097:in 'RSpec::Core::Configuration#with_suite_hooks'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:92:in 'block in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/reporter.rb:74:in 'RSpec::Core::Reporter#report'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:91:in 'KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:55:in 'KnapsackPro::Runners::Queue::RSpecRunner#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:20:in 'KnapsackPro::Runners::Queue::RSpecRunner.run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/tasks/queue/rspec.rake:12:in 'block (3 levels) in <main>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'block in Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:219:in 'block in Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Monitor#synchronize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:188:in 'Rake::Task#invoke'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:188:in 'Rake::Application#invoke_task'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block (2 levels) in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:147:in 'Rake::Application#run_with_threads'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:132:in 'Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:83:in 'block in Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:214:in 'Rake::Application#standard_exception_handling'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:80:in 'Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/exe/rake:27:in '<top (required)>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in 'Kernel#load'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in '<main>'
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/lago-api/lago-api/coverage. 0 / 0 LOC (100.0%) covered.
```

This commit adds a check to fail if the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret is not set to ensure we run the specs before merging the PR.
groyoh added a commit that referenced this pull request Jul 4, 2025
@groyoh
fix(specs): Add a check to fail if community PR
0e54ebb 
Currently, if a community PR is opened, the specs will not run because the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret will not be set. This will cause the specs to silently fail on the CI and potentially break `main`:

```
Run bundle exec rake knapsack_pro:queue:rspec
E, [2025-07-02T09:39:24.571116 #3735] ERROR -- : [knapsack_pro] {"errors" => ["invalid test suite token"]}

Finished in 0.45262 seconds (files took 5.69 seconds to load)
0 examples, 0 failures

E, [2025-07-02T09:39:24.572334 #3735] ERROR -- : [knapsack_pro] An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMethodError: undefined method 'response' for an instance of KnapsackPro::Client::Connection>
E, [2025-07-02T09:39:24.572368 #3735] ERROR -- : [knapsack_pro] Exception message: undefined method 'response' for an instance of KnapsackPro::Client::Connection
E, [2025-07-02T09:39:24.572463 #3735] ERROR -- : [knapsack_pro] Exception backtrace: /home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:12:in 'KnapsackPro::QueueAllocator::Batch#initialize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'Class#new'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'KnapsackPro::QueueAllocator#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:47:in 'KnapsackPro::QueueAllocator#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/base_runner.rb:29:in 'KnapsackPro::Runners::Queue::BaseRunner#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:181:in 'KnapsackPro::Runners::Queue::RSpecRunner#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:82:in 'block in KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
<internal:kernel>:168:in 'Kernel#loop'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:80:in 'KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:93:in 'block (2 levels) in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/configuration.rb:2097:in 'RSpec::Core::Configuration#with_suite_hooks'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:92:in 'block in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/reporter.rb:74:in 'RSpec::Core::Reporter#report'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:91:in 'KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:55:in 'KnapsackPro::Runners::Queue::RSpecRunner#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:20:in 'KnapsackPro::Runners::Queue::RSpecRunner.run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/tasks/queue/rspec.rake:12:in 'block (3 levels) in <main>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'block in Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:219:in 'block in Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Monitor#synchronize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:188:in 'Rake::Task#invoke'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:188:in 'Rake::Application#invoke_task'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block (2 levels) in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:147:in 'Rake::Application#run_with_threads'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:132:in 'Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:83:in 'block in Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:214:in 'Rake::Application#standard_exception_handling'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:80:in 'Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/exe/rake:27:in '<top (required)>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in 'Kernel#load'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in '<main>'
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/lago-api/lago-api/coverage. 0 / 0 LOC (100.0%) covered.
```

This commit adds a check to fail if the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret is not set to ensure we run the specs before merging the PR.
groyoh added a commit that referenced this pull request Jul 4, 2025
@groyoh
fix(specs): Fail the CI workflow if the PR is from a community member (…
a477513 
…#3915)

## Context

Currently, if a community PR is opened, the`KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret will not be set. This will cause the specs to silently fail on the CI and potentially break `main`:

```
Run bundle exec rake knapsack_pro:queue:rspec
E, [2025-07-02T09:39:24.571116 #3735] ERROR -- : [knapsack_pro] {"errors" => ["invalid test suite token"]}

Finished in 0.45262 seconds (files took 5.69 seconds to load)
0 examples, 0 failures

E, [2025-07-02T09:39:24.572334 #3735] ERROR -- : [knapsack_pro] An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMethodError: undefined method 'response' for an instance of KnapsackPro::Client::Connection>
E, [2025-07-02T09:39:24.572368 #3735] ERROR -- : [knapsack_pro] Exception message: undefined method 'response' for an instance of KnapsackPro::Client::Connection
E, [2025-07-02T09:39:24.572463 #3735] ERROR -- : [knapsack_pro] Exception backtrace: /home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:12:in 'KnapsackPro::QueueAllocator::Batch#initialize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'Class#new'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'KnapsackPro::QueueAllocator#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:47:in 'KnapsackPro::QueueAllocator#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/base_runner.rb:29:in 'KnapsackPro::Runners::Queue::BaseRunner#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:181:in 'KnapsackPro::Runners::Queue::RSpecRunner#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:82:in 'block in KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
<internal:kernel>:168:in 'Kernel#loop'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:80:in 'KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:93:in 'block (2 levels) in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/configuration.rb:2097:in 'RSpec::Core::Configuration#with_suite_hooks'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:92:in 'block in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/reporter.rb:74:in 'RSpec::Core::Reporter#report'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:91:in 'KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:55:in 'KnapsackPro::Runners::Queue::RSpecRunner#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:20:in 'KnapsackPro::Runners::Queue::RSpecRunner.run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/tasks/queue/rspec.rake:12:in 'block (3 levels) in <main>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'block in Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:219:in 'block in Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Monitor#synchronize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:188:in 'Rake::Task#invoke'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:188:in 'Rake::Application#invoke_task'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block (2 levels) in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:147:in 'Rake::Application#run_with_threads'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:132:in 'Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:83:in 'block in Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:214:in 'Rake::Application#standard_exception_handling'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:80:in 'Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/exe/rake:27:in '<top (required)>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in 'Kernel#load'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in '<main>'
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/lago-api/lago-api/coverage. 0 / 0 LOC (100.0%) covered.
```

See an example here: https://github.com/getlago/lago-api/actions/runs/16020160377/job/45199719035.

## Description

This commit adds a check to fail the CI workflow if the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret is not set to ensure we run the specs before merging the PR.
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@groyoh @diegocharles
fix(specs): Fail the CI workflow if the PR is from a community member (…
be763a3 
…#3915)

## Context

Currently, if a community PR is opened, the`KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret will not be set. This will cause the specs to silently fail on the CI and potentially break `main`:

```
Run bundle exec rake knapsack_pro:queue:rspec
E, [2025-07-02T09:39:24.571116 #3735] ERROR -- : [knapsack_pro] {"errors" => ["invalid test suite token"]}

Finished in 0.45262 seconds (files took 5.69 seconds to load)
0 examples, 0 failures

E, [2025-07-02T09:39:24.572334 #3735] ERROR -- : [knapsack_pro] An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMethodError: undefined method 'response' for an instance of KnapsackPro::Client::Connection>
E, [2025-07-02T09:39:24.572368 #3735] ERROR -- : [knapsack_pro] Exception message: undefined method 'response' for an instance of KnapsackPro::Client::Connection
E, [2025-07-02T09:39:24.572463 #3735] ERROR -- : [knapsack_pro] Exception backtrace: /home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:12:in 'KnapsackPro::QueueAllocator::Batch#initialize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'Class#new'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:105:in 'KnapsackPro::QueueAllocator#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/queue_allocator.rb:47:in 'KnapsackPro::QueueAllocator#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/base_runner.rb:29:in 'KnapsackPro::Runners::Queue::BaseRunner#test_file_paths'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:181:in 'KnapsackPro::Runners::Queue::RSpecRunner#pull_tests_from_queue'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:82:in 'block in KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
<internal:kernel>:168:in 'Kernel#loop'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:80:in 'KnapsackPro::Runners::Queue::RSpecRunner#with_batch'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:93:in 'block (2 levels) in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/configuration.rb:2097:in 'RSpec::Core::Configuration#with_suite_hooks'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:92:in 'block in KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rspec-core-3.13.2/lib/rspec/core/reporter.rb:74:in 'RSpec::Core::Reporter#report'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/extensions/rspec_extension.rb:91:in 'KnapsackPro::Extensions::RSpecExtension::Runner#knapsack__run_specs'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:55:in 'KnapsackPro::Runners::Queue::RSpecRunner#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/knapsack_pro/runners/queue/rspec_runner.rb:20:in 'KnapsackPro::Runners::Queue::RSpecRunner.run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/knapsack_pro-8.1.0/lib/tasks/queue/rspec.rake:12:in 'block (3 levels) in <main>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'block in Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:281:in 'Rake::Task#execute'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:219:in 'block in Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Monitor#synchronize'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:199:in 'Rake::Task#invoke_with_call_chain'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/task.rb:188:in 'Rake::Task#invoke'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:188:in 'Rake::Application#invoke_task'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block (2 levels) in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'Array#each'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:138:in 'block in Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:147:in 'Rake::Application#run_with_threads'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:132:in 'Rake::Application#top_level'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:83:in 'block in Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:214:in 'Rake::Application#standard_exception_handling'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/lib/rake/application.rb:80:in 'Rake::Application#run'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/gems/rake-13.2.1/exe/rake:27:in '<top (required)>'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in 'Kernel#load'
/home/runner/work/lago-api/lago-api/vendor/bundle/ruby/3.4.0/bin/rake:25:in '<main>'
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/lago-api/lago-api/coverage. 0 / 0 LOC (100.0%) covered.
```

See an example here: https://github.com/getlago/lago-api/actions/runs/16020160377/job/45199719035.

## Description

This commit adds a check to fail the CI workflow if the `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` secret is not set to ensure we run the specs before merging the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansmonjol ansmonjol ansmonjol approved these changes

Assignees

@julienbourdeau julienbourdeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienbourdeau @ansmonjol