fix(wallet): Optimistic locking for in advance events #3720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
approved these changes
May 26, 2025
jdenquin
approved these changes
May 26, 2025
vincent-pochet
added a commit
that referenced
this pull request
May 26, 2025
This PR is a new attempt to approach the issue of parallel wallet refresh refresh in the case of in payed in advance events. The PR moves fro pessimistic locking (`FOR UPDATE NOWAIT`) to an optimistic one using the `lock_version` already present on the wallets table. An automatic retry logic is added around the wallet decrease logic with a random wait time between each attempt. It reduce the effect of the error to the decrease logic only instead of the all event processing like it is today. Finally in case of error, the error is re-raised and the entire logic will be retried by Sidekiq
vincent-pochet
added a commit
that referenced
this pull request
May 26, 2025
This PR is a new attempt to approach the issue of parallel wallet refresh refresh in the case of in payed in advance events. The PR moves fro pessimistic locking (`FOR UPDATE NOWAIT`) to an optimistic one using the `lock_version` already present on the wallets table. An automatic retry logic is added around the wallet decrease logic with a random wait time between each attempt. It reduce the effect of the error to the decrease logic only instead of the all event processing like it is today. Finally in case of error, the error is re-raised and the entire logic will be retried by Sidekiq
vincent-pochet
added a commit
that referenced
this pull request
May 26, 2025
… (#3722) This PR removes the legacy `organizations.clickhouse_aggregation` column, that is not used anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a new attempt to approach the issue of parallel wallet refresh refresh in the case of in payed in advance events.
Description
The PR moves fro pessimistic locking (
FOR UPDATE NOWAIT) to an optimistic one using thelock_versionalready present on the wallets table.An automatic retry logic is added around the wallet decrease logic with a random wait time between each attempt. It reduce the effect of the error to the decrease logic only instead of the all event processing like it is today.
Finally in case of error, the error is re-raised and the entire logic will be retried by Sidekiq