-
Notifications
You must be signed in to change notification settings - Fork 126
feat(webhook): email admins in case of failed webhooks #3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23e0ccf
to
9e3bf72
Compare
6cb49f8
to
9dadfc6
Compare
9dadfc6
to
3834366
Compare
floganz
approved these changes
Jun 2, 2025
3834366
to
30ca1a9
Compare
30ca1a9
to
55cc3e8
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jun 2, 2025
Lago sends many webhooks to the user's system but sometimes the webhook fails. We retry the webhook 3 times, then it dies. This PR introduce a new email sent to all admins when a webhook fails to be delivered. Usually, it means there is something wrong on the receiving end. This email is sent as soon as one webhook dies but is not sent again for an hour. If the receiving endpoint is down for a few minutes, you don't get flooded! ~**The email is text only, not HTML.** This is an admin email that you should very rarely receive. It's easier than HTML.~ It's HTML. 
julienbourdeau
added a commit
that referenced
this pull request
Jun 12, 2025
## Context We recently [added this feature](#3654), then [disabled it](#3776). This PR removes it completely. ## Description Many customers have organization with failing endpoints (like staging or dev env) and it's expected because they want to see the webhooks in the dashboard. Ideally, the email should be occasional (like Stripe does). This would require more time and attention that original thought and this is very low priority. I believe it's best to revert it completely for now.
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context We recently [added this feature](#3654), then [disabled it](#3776). This PR removes it completely. ## Description Many customers have organization with failing endpoints (like staging or dev env) and it's expected because they want to see the webhooks in the dashboard. Ideally, the email should be occasional (like Stripe does). This would require more time and attention that original thought and this is very low priority. I believe it's best to revert it completely for now.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lago sends many webhooks to the user's system but sometimes the webhook fails.
We retry the webhook 3 times, then it dies.
This PR introduce a new email sent to all admins when a webhook fails to be delivered. Usually, it means there is something wrong on the receiving end.
This email is sent as soon as one webhook dies but is not sent again for an hour. If the receiving endpoint is down for a few minutes, you don't get flooded!
The email is text only, not HTML. This is an admin email that you should very rarely receive. It's easier than HTML.It's HTML.