Skip to content

Conversation

julienbourdeau
Copy link
Contributor

@julienbourdeau julienbourdeau commented May 15, 2025

Lago sends many webhooks to the user's system but sometimes the webhook fails.
We retry the webhook 3 times, then it dies.

This PR introduce a new email sent to all admins when a webhook fails to be delivered. Usually, it means there is something wrong on the receiving end.

This email is sent as soon as one webhook dies but is not sent again for an hour. If the receiving endpoint is down for a few minutes, you don't get flooded!

The email is text only, not HTML. This is an admin email that you should very rarely receive. It's easier than HTML. It's HTML.

CleanShot 2025-05-21 at 17 15 07@2x

@julienbourdeau julienbourdeau self-assigned this May 15, 2025
@julienbourdeau julienbourdeau force-pushed the feat/admin-notification-webhook-error branch 3 times, most recently from 23e0ccf to 9e3bf72 Compare May 16, 2025 09:03
@julienbourdeau julienbourdeau marked this pull request as ready for review May 16, 2025 09:40
@julienbourdeau julienbourdeau marked this pull request as draft May 16, 2025 12:07
@julienbourdeau julienbourdeau force-pushed the feat/admin-notification-webhook-error branch 2 times, most recently from 6cb49f8 to 9dadfc6 Compare May 21, 2025 15:32
@julienbourdeau julienbourdeau marked this pull request as ready for review May 21, 2025 15:37
@julienbourdeau julienbourdeau force-pushed the feat/admin-notification-webhook-error branch from 9dadfc6 to 3834366 Compare June 2, 2025 07:45
@julienbourdeau julienbourdeau force-pushed the feat/admin-notification-webhook-error branch from 3834366 to 30ca1a9 Compare June 2, 2025 10:18
@julienbourdeau julienbourdeau force-pushed the feat/admin-notification-webhook-error branch from 30ca1a9 to 55cc3e8 Compare June 2, 2025 10:27
@julienbourdeau julienbourdeau merged commit f8f50dd into main Jun 2, 2025
14 checks passed
@julienbourdeau julienbourdeau deleted the feat/admin-notification-webhook-error branch June 2, 2025 12:25
diegocharles pushed a commit that referenced this pull request Jun 2, 2025
Lago sends many webhooks to the user's system but sometimes the webhook
fails.
We retry the webhook 3 times, then it dies.

This PR introduce a new email sent to all admins when a webhook fails to
be delivered. Usually, it means there is something wrong on the
receiving end.

This email is sent as soon as one webhook dies but is not sent again for
an hour. If the receiving endpoint is down for a few minutes, you don't
get flooded!

~**The email is text only, not HTML.** This is an admin email that you
should very rarely receive. It's easier than HTML.~ It's HTML.

![CleanShot 2025-05-21 at 17 15
07@2x](https://github.com/user-attachments/assets/c321a4fa-09c5-4abb-a7e3-f412adfdf854)
julienbourdeau added a commit that referenced this pull request Jun 12, 2025
## Context

We recently [added this
feature](#3654), then [disabled
it](#3776). This PR removes it
completely.

## Description

Many customers have organization with failing endpoints (like staging or
dev env) and it's expected because they want to see the webhooks in the
dashboard.

Ideally, the email should be occasional (like Stripe does). This would
require more time and attention that original thought and this is very
low priority.

I believe it's best to revert it completely for now.
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
## Context

We recently [added this
feature](#3654), then [disabled
it](#3776). This PR removes it
completely.

## Description

Many customers have organization with failing endpoints (like staging or
dev env) and it's expected because they want to see the webhooks in the
dashboard.

Ideally, the email should be occasional (like Stripe does). This would
require more time and attention that original thought and this is very
low priority.

I believe it's best to revert it completely for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants