fix(customer): Fix email validator #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
approved these changes
May 6, 2025
4d9bac4 to
ef612d7
Compare
b16e262 to
822b4f9
Compare
822b4f9 to
708fa18
Compare
groyoh
added a commit
that referenced
this pull request
Jun 18, 2025
Our current email validation regex is too permissive, allowing invalid emails like `test email@domain.com`. This caused some invoice emails sendout failures. The main issue comes from the fact that our regex does not have `\A` and `\z` anchors, which means it can match parts of a string rather than the whole string. Another issue is that we allow `customers.email` to include multiple emails separated by commas, but our regex does not handle this correctly. The fix for this was copied from getlago/lago-api#3590.
groyoh
approved these changes
Jun 19, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jun 30, 2025
## Context Some mailer jobs fail because the recipient email is invalid. It is due to the email validator bug in case of multiple comma-separated emails, it was only validating the first one in the list. This was considered to be valid even if the second email is invalid: `email1@test-email.com, email2@test- email.com` ## Description This PR fixes the email validator.
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Context Some mailer jobs fail because the recipient email is invalid. It is due to the email validator bug in case of multiple comma-separated emails, it was only validating the first one in the list. This was considered to be valid even if the second email is invalid: `email1@test-email.com, email2@test- email.com` ## Description This PR fixes the email validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some mailer jobs fail because the recipient email is invalid.
It is due to the email validator bug in case of multiple comma-separated emails, it was only validating the first one in the list.
This was considered to be valid even if the second email is invalid:
email1@test-email.com, email2@test- email.comDescription
This PR fixes the email validator.