fix(event): Kafka payload for batch events #4220
Merged
+119
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Kafka payload for raw events is built in two places, one in the
Events::CreateService
and one inEvents::CreateBatchService
this issue is that the one from the batch service is lacking themetadata
fields.This field is a hash used by the events processor to find if the event is already post processed in the API. If not and if the event matched an in advance charge, a message is produced in the
events_charged_in_advance
topic.As the metadata was missing the event processor was considering that the event was not post-processed by the API even if it was, leading to a double processing and a duplicated fee...
Description
This PR makes sure that both
Events::CreateService
andEvents::CreateBatchService
uses the same Kafka producer service to remove the duplicated payload handling.NOTE: The duplication should have been avoided by the unique index defined at Posgres level but another bug have been identified at this level and will be fixed in a second PR.