net-libs/srt: fix build with cmake 4, allow LTO #42355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: https://bugs.gentoo.org/955894 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
The ODR violations were fixed with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
Pull Request assignmentSubmitter: @kostadinsh Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2025-05-30 17:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
gentoo-bot
pushed a commit
that referenced
this pull request
May 30, 2025
Closes: https://bugs.gentoo.org/955894 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com> Part-of: #42355 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport patch [1] to fix building with cmake 4 and allow building with LTO since the ODR violations [2][3] have been fixed upstream [4]. The test suite passes fine with LTO on amd64.
[1] Haivision/srt@0def1b1
[2] Haivision/srt#2145
[3] https://bugs.gentoo.org/861584
[4] Haivision/srt#3002
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.