[apps] Fixed verbose linkage difference. #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, let me explain. The locking was normally not necessary, and the only merit for logging is to prevent printing from different threads to be interleaved. Verb is simply redirecting to the stream (cout or cerr, depending on settings) and it's by definition thread-safe. This locking is only necessary to keep one line not interrupted by printing of the other and prevent messup in the verbose messages. Therefore it's only required in apps that uses threads and may have a situtation of printing Verb from multiple threads simultaneously. Apps like srt-test-live don't use multiple threads and so they don't use this locking. |
maxsharabayko
commented
Aug 12, 2024
kostadinsh
added a commit
to kostadinsh/gentoo
that referenced
this pull request
May 30, 2025
Upstream fixed the ODR violations with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
kostadinsh
added a commit
to kostadinsh/gentoo
that referenced
this pull request
May 30, 2025
Upstream fixed the ODR violations with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
kostadinsh
added a commit
to kostadinsh/gentoo
that referenced
this pull request
May 30, 2025
The ODR violations were fixed with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
kostadinsh
added a commit
to kostadinsh/gentoo
that referenced
this pull request
May 30, 2025
The ODR violations were fixed with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com>
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 30, 2025
The ODR violations were fixed with Haivision/srt#3002 which is included in 1.5.4. Bug: https://bugs.gentoo.org/861584 Signed-off-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com> Part-of: #42355 Closes: #42355 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRT_ENABLE_VERBOSE_LOCKbuild definition.Fixes #2145.
Notes
I am not quite sure if the implementation of the Verbose::Log with a mutex is thread safe given the
template <class V> Log& operator<<(const V& arg)is not protected by a mutex lock. What's protected is putting the end of line symbol on log destruction.Verb() << VerbLock << "Starting TargetMedium: " << this;