Added support for fractional font sizes. #407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4460,12 +4460,12 @@ void editor_set_font(GeanyEditor *editor, const gchar *font) | |||
| g_return_if_fail(editor); | |||
|
|
|||
| pfd = pango_font_description_from_string(font); | |||
| size = pango_font_description_get_size(pfd) / PANGO_SCALE; | |||
| size = (100*pango_font_description_get_size(pfd)) / PANGO_SCALE; | |||
There was a problem hiding this comment.
why multiply by 100 and divide later? wouldn't it be simpler and everything to just make size a gdouble and get a real straight away?
|
@codebrainz are you sure that the @b4n --excessively-pedantic options set won't complain about passing ints to doubles if we do that :) Otherwise @phao just put a space between the two stars |
|
@b4n ping, fixed to your satisfaction? |
b4n
pushed a commit
that referenced
this pull request
Aug 9, 2019
|
See #2250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.