Skip to content

Fix build flakiness with Read the Docs #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2025
Merged

Fix build flakiness with Read the Docs #3865

merged 3 commits into from
May 3, 2025

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented May 3, 2025

Closes #3856. Our dependencies were pretty out of date due to a delay in us upgrading to PyGObject. On ReadTheDocs, we had virtualenv pinned to an older version than what the runner had. This was causing it to downgrade during the middle of dependency installation, which resulted in a file not found error.

This PR pins PyGObject < 3.52 (to be updated in #3797) and then updates all the other dependencies to fix the issue.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #3856

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw changed the title Attempt to fix build flakiness with RTD Fix build flakiness with Read the Docs May 3, 2025
@danyeaw danyeaw marked this pull request as ready for review May 3, 2025 00:21
@danyeaw danyeaw requested a review from amolenaar May 3, 2025 00:21
@danyeaw danyeaw added the chore Maintenance related PR label May 3, 2025
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danyeaw thanks for fixing this issue

@amolenaar amolenaar merged commit cbcb67a into main May 3, 2025
26 checks passed
@amolenaar amolenaar deleted the Update-dependencies branch May 3, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadTheDocs builds have been unstable for the past weeks
2 participants