-
-
Notifications
You must be signed in to change notification settings - Fork 216
Update PyGObject #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyGObject #3797
Conversation
b12e5d8
to
cdc0f2a
Compare
9d22068
to
25a1e7a
Compare
Not for our project local deps.
It contains the right fixes for pygobject-3.52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amolenaar, these changes look great. I did notice we are still overriding PyGObject back to 3.50.x on Windows. Do you think we should update that as well or make it part of a separate PR, like the dependabot Gvsbuild updates?
What would it entail to use 3.52 on Windows? Just not installing the prebuilt wheel? |
I think that should work, but we might end up with a surprise :) |
It's not fully working. There's an issue with finding typelibs. |
Hi @amolenaar, I isolated this issue to needing to set the |
That's this line in gobject-introspection? This is also in girepository (I think). >>> from gi.repository import GIRepository
>>> GIRepository.Repository().get_search_path()
['/opt/homebrew/Cellar/glib/2.84.0_1/lib/girepository-1.0', '/opt/homebrew/lib/girepository-1.0'] Edit: |
The default path is set to |
@danyeaw I found the issue. Quick fix is to add a |
@amolenaar Nice find! |
# Conflicts: # .github/workflows/full-build.yml # poetry.lock # pyproject.toml
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Small round of dependency update. Removed upper bounds where possible. See https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/418
Does this PR introduce a breaking change?
Other information