Skip to content

Update PyGObject #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 9, 2025
Merged

Update PyGObject #3797

merged 13 commits into from
May 9, 2025

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Mar 19, 2025

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Small round of dependency update. Removed upper bounds where possible. See https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/418

  • Updating pygobject (3.50.0 -> 3.52.3)
  • Use latest (git) version for PyInstaller

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar mentioned this pull request Mar 19, 2025
6 tasks
@github-actions github-actions bot added translation Everything regarding translation, localization, and internationalization documentation labels Mar 20, 2025
@amolenaar amolenaar force-pushed the update-deps branch 2 times, most recently from b12e5d8 to cdc0f2a Compare March 20, 2025 22:04
@amolenaar amolenaar force-pushed the update-deps branch 3 times, most recently from 9d22068 to 25a1e7a Compare March 30, 2025 18:01
@github-actions github-actions bot added the python Pull requests that update Python code label Mar 30, 2025
@amolenaar amolenaar changed the title Update deps Update dependencies Mar 31, 2025
@amolenaar amolenaar changed the title Update dependencies Update PyGObject Mar 31, 2025
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amolenaar, these changes look great. I did notice we are still overriding PyGObject back to 3.50.x on Windows. Do you think we should update that as well or make it part of a separate PR, like the dependabot Gvsbuild updates?

@amolenaar
Copy link
Member Author

What would it entail to use 3.52 on Windows? Just not installing the prebuilt wheel?

@danyeaw
Copy link
Member

danyeaw commented Apr 2, 2025

I think that should work, but we might end up with a surprise :)

@amolenaar
Copy link
Member Author

It's not fully working. There's an issue with finding typelibs.

@danyeaw
Copy link
Member

danyeaw commented Apr 5, 2025

Hi @amolenaar, I isolated this issue to needing to set the GI_TYPELIB_PATH environment variable. This seems like a regression to me in gobject-introspection. It should automatically search for the typelibs in the lib\girepository-1.0 directory, since that is the normal search path.

@amolenaar
Copy link
Member Author

amolenaar commented Apr 5, 2025

That's this line in gobject-introspection? This is also in girepository (I think).

>>> from gi.repository import GIRepository
>>> GIRepository.Repository().get_search_path()
['/opt/homebrew/Cellar/glib/2.84.0_1/lib/girepository-1.0', '/opt/homebrew/lib/girepository-1.0']

Edit: GOBJECT_INTROSPECTION_RELATIVE_LIBDIR is set to libdir. Does this make it point to the wrong directory? It points to Lib.

@amolenaar
Copy link
Member Author

The default path is set to C:\\Users\\gapho\\Development\\gaphor\\.venv\\Scripts\\lib\\girepository-1.0, while with gobject-introspection it's set to C:\\gtk\\lib\\girepository-1.0.

@amolenaar
Copy link
Member Author

@danyeaw I found the issue. Quick fix is to add a -DDLL_EXPORT CFlag when compiling glib. The real fix is, I think, to remove the check for the DLL_EXPORT variable.

@danyeaw
Copy link
Member

danyeaw commented Apr 6, 2025

@amolenaar Nice find!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code translation Everything regarding translation, localization, and internationalization documentation labels May 9, 2025
@danyeaw danyeaw merged commit 60413a4 into main May 9, 2025
25 checks passed
@danyeaw danyeaw deleted the update-deps branch May 9, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants