Skip to content

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Double-click adds a model element to the active diagram. This is perceived as confusing.

Issue Number: Fixed #3262

What is the new behavior?

Do not add a new presentation to the diagram, instead select the element if it's in the diagram. Show a message if it's not in the diagram.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Dec 3, 2024
@amolenaar amolenaar requested a review from danyeaw December 3, 2024 22:25
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great update!

@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Dec 9, 2024
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 9, 2024
@amolenaar amolenaar force-pushed the double-click-select branch from 06bc58e to 4183a78 Compare December 9, 2024 07:19
Do not add a new presentation to the diagram, instead select the
element if it's in the diagram. Show a message if it's not in the diagram.
@amolenaar amolenaar force-pushed the double-click-select branch from 4183a78 to df5ff1c Compare December 9, 2024 07:30
@amolenaar amolenaar merged commit 3c251d8 into main Dec 9, 2024
23 checks passed
@amolenaar amolenaar deleted the double-click-select branch December 9, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double clicking causes cloning
2 participants