Skip to content

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Nov 6, 2024

Follow up of #3560

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

The meaning and impact of some items in the top bar is not clear:

  • The + button is placed above the diagrams, but the diagrams are placed in the selected element in the model browser
  • Close button (right-most) looks like it's closing the Property Editor, although it's closing the whole window
  • Undo/redo and scale buttons apply to the diagram, not to the property editor.

Issue Number: N/A

What is the new behavior?

This PR places the action buttons in more logical places. The Property Editor is now a utility pane. A toolbar is added with the most basic operations.

What I would like is a button to toggle the toolbar.

Screenshot 2024-11-06 at 15 46 37

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Now it's part of the diagram page.
Now that it's always visible in the header.
It looks like the right color is @sidebar_bg_color: rgb(235,235,235).
@github-actions github-actions bot added the python Pull requests that update Python code label Nov 6, 2024
@amolenaar amolenaar requested a review from danyeaw November 6, 2024 14:54
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Nov 9, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing @amolenaar, really nice job! 🤩

@danyeaw danyeaw merged commit 56f790f into main Nov 9, 2024
23 checks passed
@danyeaw danyeaw deleted the ui-redesign branch November 9, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants