Skip to content

Update Toolbox pane color to match Property Editor #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Nov 4, 2024

As pointed out by the research on User interfaces of MBSE tools and their impact on neurodivergent system architects by Mareike Victoria Keil and Oliver Bleisinger, Gaphor was using different gray colors on our Property Editor than on the Toolbox and Model Browser pane.

This PR updates the Toolbox pane to use the same color as Property Editor by setting the color to the sidebar backdrop instead of background color.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

The gray colors are slightly different

Issue Number: N/A

What is the new behavior?

The gray colors match

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the fix A fix for a bug label Nov 4, 2024
@danyeaw danyeaw requested a review from amolenaar November 5, 2024 10:41
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out.

@amolenaar amolenaar merged commit 4c74672 into main Nov 5, 2024
22 checks passed
@amolenaar amolenaar deleted the fix-sidebar-colors branch November 5, 2024 11:00
@amolenaar amolenaar mentioned this pull request Nov 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants