Presentation class inherits directly from Base #3543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presentations have no name of their own.
872a7b9 to
57bd7c9
Compare
57bd7c9 to
13245dd
Compare
|
@amolenaar Whoops, did I merge these out of order? |
|
No, they're now part of that pr. I addressed your comments and fixed the merge conflict. It should be good to go, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #3541.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Presentationinherited fromElement, which provided it with features it would never need, such as a name, ownership.Issue Number: N/A
What is the new behavior?
Presentationis now derived directly fromBase. This makes it clear that this kind of element is different from the modeling language base typeElement.Does this PR introduce a breaking change?
Other information