Skip to content

Revert KerML changes #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Revert KerML changes #3541

merged 3 commits into from
Oct 26, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Oct 19, 2024

This PR builds on #3531.

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Type, Feature and other types have been moved to the core model.

Issue Number: #3540

What is the new behavior?

Since we have strict model separation in place, those concepts can be moved back to the UML modeling language. This gives us more freedom in implementing KerML and SysMLv2 according to spec.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reverted changes made in #3365, and #3366.

CC @pbrown12303

@github-actions github-actions bot added the python Pull requests that update Python code label Oct 19, 2024
@amolenaar amolenaar force-pushed the revert-types-to-core branch from 9683f86 to 4fbfd2f Compare October 19, 2024 12:15
@amolenaar amolenaar force-pushed the revert-types-to-core branch from 6067620 to b2667f3 Compare October 19, 2024 13:56
@amolenaar amolenaar changed the title Revert types to core Revert KerML changes Oct 19, 2024
@amolenaar amolenaar requested a review from danyeaw October 19, 2024 14:58
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar, these changes look good to revert this.

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Oct 26, 2024
@danyeaw danyeaw merged commit 1a6d46a into save-model-namespace Oct 26, 2024
5 checks passed
@danyeaw danyeaw deleted the revert-types-to-core branch October 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants