Move Types to Core model #3366
Merged
Move Types to Core model #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaphor is not using any redefinable features. Removing it shouls simplify migration to KerML.
So we can more easily distinguish what's coming from the Core model.
Feature is inherited from Type now. Was RefinableElement/NamedElement.
b08be1d to
5c6542f
Compare
e32717f to
942f54d
Compare
danyeaw
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Hi @amolenaar, this changes look great - one step closer to KerML!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #3365.
PR Type
What kind of change does this PR introduce?
Issue Number: #2584
What is the new behavior?
(Partial) support for the KerML core model:
Type,FeatureRedefinableElementfrom UML modelDocs: