Revert #2329 - Gtk.ListVew for Parameters #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
approved these changes
Jul 8, 2023
|
Should we do a new release due to this error? |
amolenaar
added a commit
that referenced
this pull request
Jul 8, 2023
|
Ya, I think so as well |
amolenaar
added a commit
that referenced
this pull request
Sep 16, 2023
amolenaar
added a commit
that referenced
this pull request
Dec 15, 2023
amolenaar
added a commit
that referenced
this pull request
Dec 15, 2023
amolenaar
added a commit
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The editable label causes crashes when used in a ListView, or so it seems.
Issue Number: #2433
What is the new behavior?
Revert to
Gtk.TreeView. We need to find out why it's crashing and how to fix it.Does this PR introduce a breaking change?
Other information