Skip to content

Fingerprinting event handler #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 5, 2023
Merged

Fingerprinting event handler #3653

merged 11 commits into from
Sep 5, 2023

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Sep 4, 2023 •
edited
Loading

What does this PR do?

Add FingerprintingEventHandler to Island, to update machines when network services' data is obtained
Fixes #3000

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Checked EtE test logs to make sure there are no errors, tested manually and checked report

  • If applicable, add screenshots or log transcripts of the feature working
    Tested by Ilija:
    image

@shreyamalviya shreyamalviya force-pushed the 3000-fingerprinting-event-handler branch from e1025d9 to e4088a9 Compare September 5, 2023 05:10
@shreyamalviya shreyamalviya marked this pull request as ready for review September 5, 2023 05:38
@mssalvatore mssalvatore merged commit 6b6b1d1 into develop Sep 5, 2023
@mssalvatore mssalvatore deleted the 3000-fingerprinting-event-handler branch September 5, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Machine.network_services when new information is obtained
2 participants
@shreyamalviya @mssalvatore