Skip to content

Update Machine.network_services when new information is obtained #3000

@shreyamalviya

Description

@shreyamalviya

While testing #2999, @ilija-lazoroski found that "Scanned Servers" in the report shows "unknown" (should've been SSH).

image

This is because the UI shows Machine.network_services and that field is only updated once in ScanEventHandler when a TCPScanEvent is published. The network service is hard-coded to be updated to NetworkService.UNKNOWN.

A Machine's network_services should be updated every time we get new information about them (which is only from fingerprinting, as of now).

Tasks

Agent

Island

  • Add an agent event handler to handle FingerprintEvents and update the machine (see ScanEventHandler for inspiration) (0.25d) - @shreyamalviya
    • See setup_agent_event_handlers()
  • Refactor/rename ScanEventHandler._get_network_services_from_event() so that known network services are not overwritten (0d) @mssalvatore

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions